Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Unexpected void value expression" error #1812

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Add "Unexpected void value expression" error #1812

merged 4 commits into from
Nov 14, 2023

Conversation

makenowjust
Copy link
Contributor

@makenowjust makenowjust commented Nov 13, 2023 •
edited
Loading

TODO:

  • Add "Unexpected void value expression" error
  • Add a check function for void value expression
  • Add assertions to the parser
  • Add tests

@makenowjust makenowjust marked this pull request as ready for review November 14, 2023 08:09
@makenowjust makenowjust changed the title [WIP] Add "Unexpected void value expression" error Add "Unexpected void value expression" error Nov 14, 2023
kddnewton
kddnewton approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kddnewton kddnewton merged commit 03f8d5b into ruby:main Nov 14, 2023
46 checks passed
@kddnewton kddnewton mentioned this pull request Nov 14, 2023
Closed
@makenowjust makenowjust deleted the fix-1729 branch November 14, 2023 14:44
@makenowjust makenowjust mentioned this pull request Nov 19, 2023
Closed
@makenowjust makenowjust mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makenowjust @kddnewton