Missing void value expression checks

[enebo]

or has a lower precedence than break/next/return.

break true or false
next true or false
return true or false

ruby -I. ./bin/parse -e 'return true or false'
@ ProgramNode (location: (1,0)-(1,20))
├── locals: []
└── statements:
    @ StatementsNode (location: (1,0)-(1,20))
    └── body: (length: 1)
        └── @ OrNode (location: (1,0)-(1,20))
            ├── left:
            │   @ ReturnNode (location: (1,0)-(1,11))
            │   ├── keyword_loc: (1,0)-(1,6) = "return"
            │   └── arguments:
            │       @ ArgumentsNode (location: (1,7)-(1,11))
            │       └── arguments: (length: 1)
            │           └── @ TrueNode (location: (1,7)-(1,11))
            ├── right:
            │   @ FalseNode (location: (1,15)-(1,20))
            └── operator_loc: (1,12)-(1,14) = "or"

[kddnewton]

It should though right?

[kddnewton]

I think this is actually correct

[kddnewton]

It should error out with "void value expression" but I think the syntax tree is correct.

[enebo]

yeah I guess so. So missing error.

[makenowjust]

Should "void value expression" be produced on parsing? Or, on compiling?

[kddnewton]

@makenowjust we've generally taken the approach of moving as much into parsing as possible so that all of the implementations can benefit. So for our case, I think it should be done while parsing.

[kddnewton]

Fixes by #1812