Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Correctly sort re-ordered columns #1096

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Bugfix: Correctly sort re-ordered columns #1096

merged 9 commits into from
Nov 16, 2023

Commits on Nov 15, 2023

  1. Check data names for sorting reoredered columns

    @ashbaldry
    ashbaldry committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    19004d9 View commit details
    Browse the repository at this point in the history

  2. Enable sorting for ColReorder by default

    @ashbaldry
    ashbaldry committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    bca0d5b View commit details
    Browse the repository at this point in the history

  3. Add options to start of test script

    @ashbaldry
    ashbaldry committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    92a0880 View commit details
    Browse the repository at this point in the history

  4. add names to the columnDefs option instead of columns

    @yihui
    yihui committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    a1ffc7c View commit details
    Browse the repository at this point in the history

  5. map the column indices in the search query to the actual indices in t… 

    …he data via the column names, so that the correct columns are searched and sorted
    @yihui
    yihui committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    a7b672d View commit details
    Browse the repository at this point in the history

  6. use the searchColumn() function

    @yihui
    yihui committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7ef90b0 View commit details
    Browse the repository at this point in the history

  7. transpose the column index when the colReorder extension is enabled

    @yihui
    yihui committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    594b6b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. tweak tests

    @yihui
    yihui committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    db05314 View commit details
    Browse the repository at this point in the history

  2. add news

    @yihui
    yihui committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    118cb44 View commit details
    Browse the repository at this point in the history