Bugfix: Correctly sort re-ordered columns #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yihui
approved these changes
Nov 15, 2023
…he data via the column names, so that the correct columns are searched and sorted
This was
linked to
issues
Nov 15, 2023
|
It turns out that sorting is easier to fix, and it took me quite a while to figure out how to fix searching, thanks to your guidance. I think this PR is ready to go now. |
|
Glad I could help! Didn't realise that the search was also not working when re-ordered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The re-ordered column order isn't sent server-side, so have added the column names to the DT options. This gets passed into the server-side parameters in
columns$[[col_id]]$name(adding it todatainstead caused errors)This PR should resolve #534 , #921 and #1069