Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make all overlay options optional #9

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: make all overlay options optional #9

merged 1 commit into from
Nov 8, 2024

Conversation

dstaley
Copy link
Contributor

@dstaley dstaley commented Nov 7, 2024

This PR makes all the options on PluginOptions['overlay'] optional.

Currently, the following code throws a TypeScript error:

new ReactRefreshPlugin({ overlay: { sockHost: '...' } })

This is because the OverlayOptions type requires entry, module, and sockIntegration, despite the fact they have defaults.

@dstaley dstaley mentioned this pull request Nov 7, 2024
Merged
9 tasks
@LingyuCoder
Copy link
Contributor

Thanks

@LingyuCoder LingyuCoder merged commit 5b34bc0 into rspack-contrib:main Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstaley @LingyuCoder