chore(clerk-js): Update types for Rspack #4517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45f64b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dstaley
commented
Nov 7, 2024
| const commonForDev = () => { | ||
| return { | ||
| module: { | ||
| rules: [svgLoader(), ...typescriptLoaderDev(), clerkUICSSLoader()], | ||
| }, | ||
| plugins: [new ReactRefreshPlugin({ overlay: { sockHost: devUrl.host } })], | ||
| plugins: [new ReactRefreshPlugin(/** @type {any} **/ ({ overlay: { sockHost: devUrl.host } }))], |
There was a problem hiding this comment.
This cast is to workaround a type issue that I've opened a PR for. rspack-contrib/rspack-plugin-react-refresh#9
alexcarpenter
approved these changes
Nov 7, 2024
tmilewski
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects the JSDoc types in our
rspack.config.jsfile along with enabling type checking via@ts-check.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change