Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert rsk_protocalVersion return value to hex #2134

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

rmoreliovlabs
Copy link
Contributor

Description

Updated the eth_protocolVersion method so its return value is a hexadecimal String instead of an Integer.

Motivation and Context

As per the Rootstock documentation the eth_protocolVersion method should return the current ethereum protocl version number as a hexadecimal, but it currently returns it as a decimal number.

How Has This Been Tested?

curl --location 'http://localhost:4444' \
--header 'Content-Type: application/json' \
--data '{
	"jsonrpc":"2.0",
	"id":666,
	"method":"eth_protocolVersion"
}'

// Should return
{"jsonrpc":"2.0","id":666,"result":"0x32"}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@rmoreliovlabs rmoreliovlabs force-pushed the update_protocol_version_response branch from c382316 to 8cebafd Compare September 27, 2023 12:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Vovchyk Vovchyk merged commit e06686f into master Sep 27, 2023
5 checks passed
@Vovchyk Vovchyk deleted the update_protocol_version_response branch September 27, 2023 12:38
@aeidelman aeidelman added this to the Fingerroot 5.3.0 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants