Merge pull request #2134 from rsksmart/update_protocol_version_response

Convert rsk_protocalVersion return value to hex
rsksmart · Sep 27, 2023 · e06686f · e06686f
2 parents b05236e + 8cebafd
commit e06686f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rskj-core/src/main/java/org/ethereum/rpc/Web3Impl.java b/rskj-core/src/main/java/org/ethereum/rpc/Web3Impl.java
@@ -281,7 +281,7 @@ public String rsk_protocolVersion() {
                 }
             }
 
-            return s = Integer.toString(version);
+            return s = HexUtils.toQuantityJsonHex(version);
         } finally {
             if (logger.isDebugEnabled()) {
                 logger.debug("rsk_protocolVersion(): {}", s);

diff --git a/rskj-core/src/test/java/org/ethereum/rpc/Web3ImplTest.java b/rskj-core/src/test/java/org/ethereum/rpc/Web3ImplTest.java
@@ -153,7 +153,7 @@ void eth_protocolVersion() {
 
         String netVersion = web3.eth_protocolVersion();
 
-        assertEquals(0, netVersion.compareTo("1"), "RSK net version different than one");
+        assertEquals(0, netVersion.compareTo("0x1"), "RSK net version different than one");
     }
 
     @Test
-Original file line number
+Diff line change
@@ Expand Up / @@ -153,7 +153,7 @@ void eth_protocolVersion() { @@
             String netVersion = web3.eth_protocolVersion();
-            assertEquals(0, netVersion.compareTo("1"), "RSK net version different than one");
+            assertEquals(0, netVersion.compareTo("0x1"), "RSK net version different than one");
         }
         @Test
@@ Expand Down @@