forked from matter-labs/zksync
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROLLUP-471/fix-deployment #109
Merged
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fb74531
fix(dev-ticker): install ca-certificates to avoid cert verification i…
antomor c06e2c4
fix: update dev-ticker image of all the docker-compose files
antomor d9dff63
chore: fix typo in comment
antomor 9769cf1
fix: load chain config only instead of all the config
antomor 8ef8150
fix(fee_ticker): do not retrieve market volume for RBTC, RDOC, USDRIF
antomor 5d58d1d
fix: create mnemonic using the rsk path
antomor f0bb897
style: apply fmt and lint
antomor aefcf4c
fix: update docker-compose to use the latest dev-ticker
antomor f000a14
build: updated server version in docker-compose
antomor ddbe254
fix: use the uppercase symbol when comparing tokens
antomor dc6bcf3
build: updated server version in docker-compose
antomor 5cc05ac
style: apply zk fmt
antomor 415e5f6
refactor: fix dev ticker
franciscotobar 16b1216
ci: rename docker-compose-runner.yml and fix ci
antomor 3b6456c
ci: fix dev-ticker restart
antomor 1ef58df
fix: fix ci by creating an empty dev.env file
antomor 622c231
fix: fix ci by starting dev-ticker
franciscotobar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that locally we dont need the
ZKSYNC_HOME
, since the component in the dev-ticker that use it, is not necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right we don't need it, but I preferred to include it to avoid confusion about it in the different envs.
If we want to remove it from here, we could just add a comment in the other
docker-compose.*.yml
files