-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROLLUP-471/fix-deployment #109
Conversation
@franciscotobar the unit/integration test flow is failing because we don't define the zksync env in the GH workflow |
@@ -35,7 +35,7 @@ services: | |||
start_period: 15s | |||
|
|||
dev-ticker: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that locally we dont need the ZKSYNC_HOME
, since the component in the dev-ticker that use it, is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right we don't need it, but I preferred to include it to avoid confusion about it in the different envs.
If we want to remove it from here, we could just add a comment in the other docker-compose.*.yml
files
3d306f6
to
ca50bf2
Compare
ca50bf2
to
622c231
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
Why