-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move opensuse-leap-15.4 to eol directory #1464
Conversation
Seems that regexp for towncrier snippets does not like dots in filename. Should I fix the name or can we ignore it? |
I think yes. Reported here: sanitizers/chronographer-github-app#44 |
@xsuchy I haven't checked your towncrier use yet, but it's not just the bot, the underlying tool itself parses the fragments similarly since period-delimited components have defined semantics, unless the fragment is orphaned. My immediate instinct would be fixing the file name. |
@webknjaz I will fix the filename. That is not a problem. But I normally executed |
Leap 15.4 EOLed at 07 Dec 2023 according to https://endoflife.date/opensuse
File renamed. |
The first part Have you tried The bot fails because it expects the identifier to be a number. The traditional use is putting an issue or a PR ID there, which is the common pattern the bot facilitates originally. I'll need to think if that could be improved. |
Oh, wait, the number comes after the category. So towncrier will thing that |
We are using a custom template: Line 6 in acf15e8
And the overall use of towncrier is non-standard (the tool doesn't seem to ready to handle monorepos, and we should somehow standardize our release policies for release notes). The commit looks good, merging! Thank you. |
2e20bae
into
rpm-software-management:main
@praiskup yeah, I've found it already. For monorepos, you could have multiple configs and run towncrier once per each subproject, making multiple change log files that you'd then merge in post-processing, I suppose. You can also have multiple configs for different audiences in the same project, a-la scriv, by calling towncrier differently. If you can outline the needs, I can look into it more in-depth. |
Leap 15.4 EOLed at 07 Dec 2023 according to https://endoflife.date/opensuse