Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems like period/dot in filename breaks the GH action #44

Open
praiskup opened this issue Sep 25, 2024 · 2 comments
Open

Seems like period/dot in filename breaks the GH action #44

praiskup opened this issue Sep 25, 2024 · 2 comments

Comments

@praiskup
Copy link

praiskup commented Sep 25, 2024

The leap-15.4.config has not been detected: rpm-software-management/mock#1464

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@webknjaz
Copy link
Member

Technically, that's expected due to the semantics of how Towncrier itself perceives the fragments. You probably need to fix your usage of Towncrier. Either replace the period with an underscore or a dash, or perhaps even go for an orphan fragment (starting with a leading + which is special-cased in Towncrier).
Usually, the first part is the issue/PR number to be linked. Why didn't you want to follow that format?

@praiskup
Copy link
Author

I opened this, because we hit a real-life issue with towncrier:

$ towncrier create foo.bar.baz.config
Created news fragment at /home/praiskup/rh/projects/mock/mock/releng/release-notes-next/foo.bar.baz.config

At least we were allowed to create such file, I assumed that it "is a correct snippet" then, and I'd expect that the action accepts it as well. But is this a bug of towncrier create?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants