PackageQuery: Source rpms do not upgrade binary ones #1310
Conversation
Noarch packages can be used to upgrade any binary packages, but not source packages. Fixes incorrect filter_upgrades() behaviour where src packages were returned as upgrade candidates for noarch packages.
Now filter_upgrades does not return source packages as upgrade candidates to binary packages.
| } | ||
| if (updated->arch != ARCH_NOARCH && solvable->arch != ARCH_NOARCH) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
LGTM, this condition is really good one. Interesting thing is that this condition will still create incorrect result for packages with incompatible architecture.
When installed package is pkgA-1-1.noarch and available are pkgA-2-1.x86_64 and pkgA-2-1.s390 both will be considered as upgrades regardless of system architecture. Fortunately it requires 2 rare conditions. I do not think that we should resolve the issue, because for the final decision we have a solver.
There was a problem hiding this comment.
Well, although the .s390 version is not installable, it still is (unlike the source rpm) a possible upgrade to a .noarch package. It depends on what we want from filter_upgrades() to exactly do... Btw we need to document this filter (I've just checked the package_query.hpp header file and found that the documentation is virtually missing).
Noarch packages can be used to upgrade any binary packages, but not source
packages. Fixes incorrect filter_upgrades() behaviour where src packages
were returned as upgrade candidates for noarch packages.
Tests adjustment: rpm-software-management/ci-dnf-stack#1472