Skip to content

Commit

Permalink
dnf5: Remove redundant arch filters
Browse files Browse the repository at this point in the history
Now filter_upgrades does not return source packages as upgrade
candidates to binary packages.
  • Loading branch information
m-blaha authored and j-mracek committed Mar 18, 2024
1 parent f1b84c6 commit 1234667
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions dnf5/commands/check-upgrade/check-upgrade.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,6 @@ void CheckUpgradeCommand::run() {

upgrades_query.filter_upgrades();

// Source RPMs should not be reported as upgrades, e.g. when the binary
// package is marked exclude and only the source package is left in the
// repo
upgrades_query.filter_arch({"src", "nosrc"}, libdnf5::sack::QueryCmp::NOT_EXACT);

libdnf5::rpm::PackageQuery installed_query(ctx.base);
installed_query.filter_installed();

Expand Down
1 change: 0 additions & 1 deletion dnf5/commands/list/list.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ void ListCommand::run() {
case PkgNarrow::UPGRADES:
base_query.filter_priority();
base_query.filter_upgrades();
base_query.filter_arch({"src", "nosrc"}, libdnf5::sack::QueryCmp::NEQ);
base_query.filter_latest_evr();
package_matched |= sections->add_section("Available upgrades", base_query, colorizer);
break;
Expand Down

0 comments on commit 1234667

Please sign in to comment.