Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface refactor #71

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Interface refactor #71

wants to merge 4 commits into from

Conversation

bsutherland333
Copy link
Collaborator

This is a refactor of is-a to has-a for the relationship between ROSplane and ROS for the estimator. The remaining nodes still need to be done. This make the relationship between ROS and the estimator more clear and better separates ROS from the estimator, allowing for estimator development outside of a ROS environment and making it easier to keep the classes separate from each other (like those parameters owned by the ROS class being used two inheritances down, which I changed).

@bsutherland333
Copy link
Collaborator Author

I don't think I'm going to have time to work on this going forward @iandareid and @JMoore5353. The estimator has been fully refactored, but none of the other classes have. When you go through and do a large refactor of ROSplane you can consider making use of this, if you like the idea of this kind of relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants