Set individual params in manager #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that when using the declare_param function with the string datatype, unless the value was explicitly instantiated as a string (std::string("value") instead of "value"), the value would get cast to a bool
JMoore5353
force-pushed
the
set-individual-params-in-manager
branch
from
f0aaef2 to
cafa745
Compare
|
Looks good! In case you are looking at the commit history, I thought, based on some testing, that the set_parameters method wasn't needed, so I deleted it, but then realized that my tests weren't complete. So I added it back in, since we do need the function calls to set_parameters. |
JMoore5353
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add the ability to change previously declared parameters in code. It also renames some of the functions to explicitly include the datatype related to that parameter, as I found declare_param("string", "value") would get mapped to the bool overload instead of the string one. Only declare_param("string", std::string("value")) resulted in correct behavior.