Move udp_board and rosflight_firmware to sim package #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of pull request #408 from the firmware repo and pull request #148 from this repo, I am moving the firmware submodule and the udp_board class directly into the rosflight_sim package.
The motivation for this stems from the fact that both the firmware and the udp_board are only intended to be used for simulation purposes, and were originally separated only to avoid requiring gazebo dependencies if someone wanted to build off of udp_board. However, having both a ROS package named rosflight_firmware and a non-ROS repository named rosflight_firmware is a bit confusing, and we have plans to make the sim package more modular so it could be built without gazebo if so desired anyways.
Do to this, I put udp_board directly into the rosflight_sim package, with rosflight_firmware existing as a separate library within rosflight_sim. Currenlty the build files for the rosflight_firmware is found in the CMakeList.txt file for the rosflight_sim package, but this could be moved directly into the firmware repo if so desired. This would put ROS files in a non-ROS repo though.