support 'Show Stack' feature on catkin packages #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanpauno
reviewed
Oct 13, 2020
There was a problem hiding this comment.
Though uncommon, I think that one package can be part of more than one metapackage.
How is that case handled?
I think that that maybe wasn't true in the case of rosbuild stacks (I've never used that).
Besides that, this looks like a reasonable addition to me.
| stackname = name | ||
| else: | ||
| # for old dry package | ||
| stackname = self.rospack.stack_of(package_name) |
There was a problem hiding this comment.
shouldn't the method in rospack be updated instead of handling the two cases differently here?
I'm not sure if that change in rospack would affect other places or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-enable old "Show Stack" features for catkin metapackages