[jsk_interactive_marker] Explicitly resolve dependency for jsk_recognition_utils in package.xml

[YutoUchimi]

jsk_recognition_utils package is installed in dependent pacakges such as jsk_rviz_plugins, but jsk_recognition_utils is imported or included in some files in jsk_interactive_marker package (e.g. jsk_interactive_marker/scripts/transformable_markers_client.py).

So I think it desirable to explicitly install that package from jsk_interactive_marker.

[k-okada]

can you visualize current dependency graph using rqt_dep ?

[YutoUchimi]

OK. This is the image of dependency graph.

[YutoUchimi]

... and here is the dependency graph in DOT format.

https://drive.google.com/open?id=1Vcg-pshcnJQ1iPYFkmFvUCXuRUCmkboY

[k-okada]

This is my fault, we need not just a graph, but the graph that explain/show the dependency easily, you can modify dependency level. Old rqt_graph can show the stack as rectangle, and may be you can add code to support meta packages.

…

-- ◉ Kei Okada 2018-07-24 19:42 GMT+09:00 Yuto Uchimi <[email protected]>:

OK. This is the image of dependency graph. [image: rospackgraph_jsk_interactive_marker resized] <https://user-images.githubusercontent.com/22876283/43133311-5834f698-8f79-11e8-977a-559149544705.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#699 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeG3PG4efc2T6GyT7IDEKBIueBvS0fsks5uJvn4gaJpZM4VLGw9> .

[YutoUchimi]

These are the packages which jsk_interactive_marker depends on.

• dependency level = 1
  

• dependency level = 2
  

• dependency level = 2 (part of graph)
  

As shown in images above, only jsk_rviz_plugins directly depnds on jsk_recognition_utils before this PR.

[k-okada]

@YutoUchimi please use ros-visualization/rqt_dep#6 to visualize dependencies.

[YutoUchimi]

Visualizing with ros-visualization/rqt_dep#6

• dependency level = 1
  

• dependency level = 2
  

• dependency level = 2 (part of graph)
  

[k-okada]

ok #666 (comment) says

jsk_rviz_plugins depends on jsk_recognition_msgs and jsk_recognition_utils at build time.
jsk_pcl_ros depends on jsk_rviz_plugins at run time.

and now jsk_interactive_marker also depends on jsk_recognition_utils at build time
note that for example some package in jsk_recognition depends on jsk_visualization
but we may not explicitly add dependencies

jsk_recognition$ grep -ri jsk_interac *
jsk_pcl_ros/CHANGELOG.rst:  this nodelet is supposed to be used with jsk_interactive_marker/bounding_box_marker
jsk_pcl_ros/launch/pcl_roi_remote.launch:    <node pkg="jsk_interactive_marker"
jsk_pcl_ros/launch/octomap_object_model_generation.launch:  <node pkg="jsk_interactive_marker"
jsk_pcl_ros/launch/organized_multi_plane_segmentation.launch:  <node pkg="jsk_interactive_marker"
jsk_pcl_ros/launch/pr2_tilt_laser_multi_plane_segmentation.launch:  <node pkg="jsk_interactive_marker"
jsk_pcl_ros/launch/snapit.launch:  <node pkg="jsk_interactive_marker" type="marker_6dof" name="marker">
jsk_pcl_ros/launch/tabletop_tracking.launch:  <node pkg="jsk_interactive_marker"
jsk_pcl_ros/launch/valve_detection.launch:    <node pkg="jsk_interactive_marker" type="polygon_marker" name="polygon_marker">
jsk_pcl_ros/sample/sample_boundingbox_occlusion_rejector.launch:  <node pkg="jsk_interactive_marker" type="marker_6dof" name="sensor_frame">
jsk_pcl_ros/sample/sample_boundingbox_occlusion_rejector.launch:  <node pkg="jsk_interactive_marker" type="marker_6dof" name="target_frame">
jsk_pcl_ros/sample/sample_boundingbox_occlusion_rejector.launch:  <node pkg="jsk_interactive_marker" type="dummy_camera.py" name="dummy_camera">
jsk_pcl_ros/sample/sample_plane_supported_cuboid_estimator.launch:  <node pkg="jsk_interactive_marker" type="marker_6dof" name="sensor_frame">
jsk_pcl_ros/sample/sample_plane_supported_cuboid_estimator.launch:  <node pkg="jsk_interactive_marker" type="dummy_camera.py" name="dummy_camera">
jsk_pcl_ros/sample/tabletop_object_detector.launch:  <node name="bounding_box_marker" pkg="jsk_interactive_marker" type="bounding_box_marker"
jsk_perception/launch/color_histogram_matcher_openni.launch:  <node pkg="jsk_interactive_marker"
jsk_recognition_utils/CHANGELOG.rst:  * Stop depending on jsk_interactive_marker