Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructuring for example_2 #233

Merged
merged 20 commits into from
Feb 20, 2023
Merged

Restructuring for example_2 #233

merged 20 commits into from
Feb 20, 2023

Conversation

christophfroehlich
Copy link
Contributor

following #231

@christophfroehlich
Copy link
Contributor Author

@destogl is this structure fine for you? subfolders without packages (hardware/bringup) and installed in shared?
is the namespace for the hw-interface also fine? as it is now it cannot be loaded by the ressource manager btw, with some unhelpful stack traces as error output. I'll investigate this further tomorrow

@christophfroehlich
Copy link
Contributor Author

as it is now it cannot be loaded by the ressource manager btw, with some unhelpful stack traces as error output. I'll investigate this further tomorrow

the problem with the hardware interface was a blank in the PLUGINLIB_EXPORT_CLASS macro fbf35e1.

@christophfroehlich christophfroehlich marked this pull request as ready for review February 7, 2023 08:29
destogl
destogl approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I agree, just a few small comments.

How do you like the structure? Is it clear enough for you?

@Xi-HHHM please check this too.

README.md Show resolved Hide resolved
example_2/CMakeLists.txt Show resolved Hide resolved
example_2/CMakeLists.txt Outdated Show resolved Hide resolved
example_2/README.rst Show resolved Hide resolved
example_2/README.rst Show resolved Hide resolved
example_2/description/rviz/diffbot_view.rviz Show resolved Hide resolved
example_2/hardware/include/ros2_control_demo_example_2/visibility_control.h Outdated Show resolved Hide resolved
example_2/package.xml Outdated Show resolved Hide resolved
example_2/ros2_control_demo_example_2.xml Show resolved Hide resolved
@christophfroehlich
Copy link
Contributor Author

is this enough for #87 already?

destogl
destogl reviewed Feb 9, 2023
View reviewed changes
example_2/package.xml Outdated Show resolved Hide resolved
@destogl destogl linked an issue Feb 9, 2023 that may be closed by this pull request
Write documentation for dif drive example merged in #70 #87
Closed
@destogl destogl mentioned this pull request Feb 9, 2023
Open
25 tasks
@christophfroehlich
Copy link
Contributor Author

CI fails due to example_1 folder, merge #234 first

@destogl destogl marked this pull request as draft February 20, 2023 12:16
@destogl destogl marked this pull request as ready for review February 20, 2023 12:16
@destogl destogl merged commit 76f703e into ros-controls:new-structure-of-master Feb 20, 2023
@christophfroehlich christophfroehlich deleted the example_2 branch February 20, 2023 17:57
destogl added a commit that referenced this pull request Mar 8, 2023
@christophfroehlich @destogl
[Example 2] Moving and Restructuring (#233)
30a70ce 
Co-authored-by: Dr. Denis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar Awaiting requested review from bmagyar

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@duringhof duringhof Awaiting requested review from duringhof

@erickisos erickisos Awaiting requested review from erickisos

@mhubii mhubii Awaiting requested review from mhubii

@Serafadam Serafadam Awaiting requested review from Serafadam

@anfemosa anfemosa Awaiting requested review from anfemosa

@destogl destogl Awaiting requested review from destogl

@harderthan harderthan Awaiting requested review from harderthan

@homalozoa homalozoa Awaiting requested review from homalozoa

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write documentation for dif drive example merged in #70
2 participants
@christophfroehlich @destogl