Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiversion: Use iron for cloned repositories #194

Merged
merged 2 commits into from
Dec 20, 2023
+36 −1
Merged

Multiversion: Use iron for cloned repositories #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23a45ff
Use iron for cloned repositories
christophfroehlich Nov 4, 2023
b2d1cdc
Add multiversion job for PRs
christophfroehlich Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/sphinx-check-page.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: "Build Multiversion Page (PR)"
on:
workflow_dispatch:
pull_request:

jobs:
build-multiversion:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-python@v4
with:
python-version: '3.10'
cache: 'pip'
- name: Install Python dependencies
run: |
python -m pip install --upgrade pip
pip install --upgrade --requirement requirements.txt
shell: bash
- name: Install generate_parameter_library
run: |
cd
git clone https://github.com/PickNikRobotics/generate_parameter_library.git
cd generate_parameter_library/generate_parameter_library_py/
python -m pip install .
shell: bash
- name: Install doxygen and graphviz
run: sudo apt-get install -y doxygen graphviz
- name: Build multiversion with API
run: |
git config --local user.email "[email protected]"
git config --local user.name "GitHub Action"
make multiversion-with-api
2 changes: 1 addition & 1 deletion make_help_scripts/deploy_defines
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ api_branch="master"
# definitions for multiversion
# branches on which the temporary commits are created and which branch should be checked out in the subrepositories
# ["branch checked out for multiversion"]="branch checked out for all subrepos"
declare -A branch_version=( ["foxy"]="foxy" ["galactic"]="galactic" ["humble"]="humble" ["iron"]="master" ["master"]="master") # master is rolling
declare -A branch_version=( ["foxy"]="foxy" ["galactic"]="galactic" ["humble"]="humble" ["iron"]="iron" ["master"]="master") # master is rolling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think, when is the right time to remove Foxy and Galactic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question.
The packages are still released, so one can still install it via package manager on Ubuntu 20.04 for example. Will this be deleted anytime? Maybe we should just add a disclaimer on top that these are EOL versions (as it is on docs.ros.org), it is no additional effort for us to keep them online.

Furthermore, I observed that some users do not see that they are reading the rolling version but use an older distro. Maybe we should add a landing page like on docs.ros.org and add a disclaimer also to the rolling-version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint added with #201


# the subrepos which are cloned into the branches and, optionally, their corresponding PR for checkout
declare -A subrepo_url=( ["ros2_control"]="https://github.com/ros-controls/ros2_control" ["ros2_controllers"]="https://github.com/ros-controls/ros2_controllers" ["ros2_control_demos"]="https://github.com/ros-controls/ros2_control_demos" ["gazebo_ros2_control"]="https://github.com/ros-controls/gazebo_ros2_control" ["gz_ros2_control"]="https://github.com/ros-controls/gz_ros2_control")
Expand Down
Loading