Multiversion: Use iron for cloned repositories #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
reviewed
Nov 5, 2023
| @@ -17,7 +17,7 @@ api_branch="master" | |||
| # definitions for multiversion | |||
| # branches on which the temporary commits are created and which branch should be checked out in the subrepositories | |||
| # ["branch checked out for multiversion"]="branch checked out for all subrepos" | |||
| declare -A branch_version=( ["foxy"]="foxy" ["galactic"]="galactic" ["humble"]="humble" ["iron"]="master" ["master"]="master") # master is rolling | |||
| declare -A branch_version=( ["foxy"]="foxy" ["galactic"]="galactic" ["humble"]="humble" ["iron"]="iron" ["master"]="master") # master is rolling | |||
There was a problem hiding this comment.
What do you think, when is the right time to remove Foxy and Galactic?
There was a problem hiding this comment.
good question.
The packages are still released, so one can still install it via package manager on Ubuntu 20.04 for example. Will this be deleted anytime? Maybe we should just add a disclaimer on top that these are EOL versions (as it is on docs.ros.org), it is no additional effort for us to keep them online.
Furthermore, I observed that some users do not see that they are reading the rolling version but use an older distro. Maybe we should add a landing page like on docs.ros.org and add a disclaimer also to the rolling-version?
There was a problem hiding this comment.
hint added with #201
destogl
approved these changes
Nov 5, 2023
christophfroehlich
changed the title
christophfroehlich
force-pushed
the
switch_iron
branch
from
ba4094d to
b2d1cdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs iron branch of