Cache nonParameterCharacterSet to help minimize memory footprint in m…

…ultithreaded apps using SOCKit Relevant github.com pull request into SOCKit is located here: NimbusKit#26
robinhoodmarkets · Jul 7, 2015 · bcdea2a · bcdea2a
1 parent 332441c
commit bcdea2a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/SOCKit.m b/src/SOCKit.m
@@ -72,11 +72,13 @@ - (id)copyWithZone:(NSZone *)zone {
 
 - (NSCharacterSet *)nonParameterCharacterSet {
   static NSCharacterSet* staticNonParameterCharacterSet = nil;
-  if (staticNonParameterCharacterSet == nil) {
+  static dispatch_once_t onceToken;
+  dispatch_once(&onceToken, ^{
     NSMutableCharacterSet* parameterCharacterSet = [NSMutableCharacterSet alphanumericCharacterSet];
     [parameterCharacterSet addCharactersInString:@".@_"];
     staticNonParameterCharacterSet = [parameterCharacterSet invertedSet];
-  }
+  });
+
   return staticNonParameterCharacterSet;
 }