Cache nonParameterCharacterSet in SOCKit.m to avoid memory spikes

robinhoodmarkets · Jul 7, 2015 · 332441c · 332441c
1 parent 90937fd
commit 332441c
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/SOCKit.m b/src/SOCKit.m
@@ -71,10 +71,13 @@ - (id)copyWithZone:(NSZone *)zone {
 #pragma mark - Pattern Compilation
 
 - (NSCharacterSet *)nonParameterCharacterSet {
-  NSMutableCharacterSet* parameterCharacterSet = [NSMutableCharacterSet alphanumericCharacterSet];
-  [parameterCharacterSet addCharactersInString:@".@_"];
-  NSCharacterSet* nonParameterCharacterSet = [parameterCharacterSet invertedSet];
-  return nonParameterCharacterSet;
+  static NSCharacterSet* staticNonParameterCharacterSet = nil;
+  if (staticNonParameterCharacterSet == nil) {
+    NSMutableCharacterSet* parameterCharacterSet = [NSMutableCharacterSet alphanumericCharacterSet];
+    [parameterCharacterSet addCharactersInString:@".@_"];
+    staticNonParameterCharacterSet = [parameterCharacterSet invertedSet];
+  }
+  return staticNonParameterCharacterSet;
 }
 
 - (void)_compilePattern {