Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: variable vnode count support in batch/streaming scheduler #18407

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Sep 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This is a progress towards #15900.

This PR refactors the batch & streaming scheduler.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao force-pushed the bz/var-vnode-vnode-struct branch from 574ee3f to 9c99bd7 Compare September 4, 2024 09:14
@BugenZhao BugenZhao force-pushed the bz/var-vnode-vnode-struct branch from 9c99bd7 to e1ad5ea Compare September 5, 2024 06:06
@BugenZhao BugenZhao marked this pull request as ready for review September 5, 2024 06:31
Base automatically changed from bz/var-vnode-vnode-struct to main September 5, 2024 09:25
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scale part lgtm

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 8d5b62b Sep 9, 2024
31 of 32 checks passed
@BugenZhao BugenZhao deleted the bz/var-vnode-more branch September 9, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants