feat: support per-fragment vnode count #18444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
32d0692 to
afe9e79
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
3292eed to
c4772c9
Compare
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
afe9e79 to
f168f35
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
c4772c9 to
166d631
Compare
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
f168f35 to
be13c79
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
166d631 to
31e2d77
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
be13c79 to
18e0165
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
3 times, most recently
from
a5afcdf to
fce41b8
Compare
BugenZhao
changed the title
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
23435d7 to
01ee86d
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
2 times, most recently
from
fa288c5 to
e4ef75f
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
2 times, most recently
from
640e7d8 to
fe25c89
Compare
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-storage
branch
from
34bdd9b to
8b31007
Compare
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
fe25c89 to
4ae30fd
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/var-vnode-user-facing-local
branch
from
0d6830b to
db14e46
Compare
Signed-off-by: Bugen Zhao <[email protected]>
yezizp2012
approved these changes
Sep 24, 2024
| .add_column( | ||
| ColumnDef::new(Table::VnodeCount) | ||
| .integer() | ||
| .default(VNODE_COUNT), |
There was a problem hiding this comment.
Suggested change
| .default(VNODE_COUNT), | |
| .default(VNODE_COUNT) | |
| .not_null(), |
Nits, better to keep consistent with model definition since the column type is not Option<i32>.
This column always has a value during initialization and updates, so it doesn't matter whether set it not null or not. Feel free to change it or not.
There was a problem hiding this comment.
Thanks. Will address in following PRs.
| .add_column( | ||
| ColumnDef::new(Fragment::VnodeCount) | ||
| .integer() | ||
| .default(VNODE_COUNT), |
BugenZhao
added a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Bugen Zhao <[email protected]>
4 tasks
BugenZhao
added a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
added a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is a progress towards #15900.
In previous PRs, we mainly focused on refactoring codes from different modules to avoid directly referencing the global constant of
VirtualNode::COUNT, but infer it from the context or directly accept it as a parameter.In this PR, we introduce the
vnode_countfield forTableandStreamFragmentGraph, update the logic for its maintenance. Many TODOs of directly usingVirtualNode::COUNTare fixed by reading the values fromFragmentorTableDesc.Note that there's still no user-facing changes in this PR, but we are now quite close to that. However, there are still some unaddressed TODOs that may require changes in behavior. We leave this in future PRs.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.