Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13 - waypoints only #14

Merged
merged 1 commit into from
Mar 12, 2020
Merged

#13 - waypoints only #14

merged 1 commit into from
Mar 12, 2020

Conversation

Gizmotronn
Copy link
Contributor

What I've done here is remove the smooth reward function that @wakeuplearn added. This was supposed to be able to do the same thing as the waypoints in the reward function, but without the waypoints. Edwin's added waypoints and this smooth function, so I've highlighted this in #13 as well as this PR

@Gizmotronn Gizmotronn added documentation Improvements or additions to documentation duplicate This issue or pull request already exists aws acord published on github/acord-robotics/stellarios/issues labels Mar 10, 2020
@Gizmotronn Gizmotronn requested a review from wakeuplearn March 10, 2020 18:56
@Gizmotronn Gizmotronn self-assigned this Mar 10, 2020
Gizmotronn
Gizmotronn commented Mar 10, 2020
View reviewed changes
Copy link
Contributor Author

@Gizmotronn Gizmotronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, both the waypoints & "smooth function" still exist here, so that will need to be changed. However, I've highlighted this here

@Gizmotronn Gizmotronn mentioned this pull request Mar 11, 2020
Merged
@Gizmotronn Gizmotronn merged commit f0d27db into IrisDroidology-patch-1 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wakeuplearn wakeuplearn Awaiting requested review from wakeuplearn

Assignees

@Gizmotronn Gizmotronn

Labels
acord published on github/acord-robotics/stellarios/issues aws documentation Improvements or additions to documentation duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gizmotronn