Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update collecting metrics page #62

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Update collecting metrics page #62

merged 2 commits into from
Jan 17, 2024

Conversation

simonpasquier
Copy link
Contributor

@simonpasquier simonpasquier commented Jan 9, 2024 •
edited
Loading

Fixes #63

@simonpasquier simonpasquier changed the title Update collecting metrics2 Update collecting metrics page Jan 9, 2024
danielmellado
danielmellado approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@danielmellado danielmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

machine424
machine424 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon, LGTM

@jan--f jan--f merged commit b255716 into rhobs:main Jan 17, 2024
5 checks passed
@simonpasquier simonpasquier deleted the update-collecting-metrics2 branch January 18, 2024 10:29
@simonpasquier simonpasquier mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machine424 machine424 machine424 approved these changes

@danielmellado danielmellado danielmellado approved these changes

@rexagod rexagod Awaiting requested review from rexagod

@jan--f jan--f Awaiting requested review from jan--f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elaborate on CPO's role
4 participants
@simonpasquier @danielmellado @machine424 @jan--f