MON-3346: add kube-rbac-proxy #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed some of my own changes without noticing the review, I'll incorporate the suggested changes. |
rexagod
force-pushed
the
add-krp
branch
4 times, most recently
from
88ebb4b
to
fc33584
Compare
|
@simonpasquier WRT #59 (review), I think the first point is covered now, however, I'm not sure what the second one refers to. Is it the KRP configuration as the (KRP) API frontend that we want to document further (I've added a couple of resource and non-resource examples based on the config present in CMO)? PLMK if I'm missing anything here. :) |
sthaha
reviewed
Sep 6, 2023
sthaha
reviewed
Sep 6, 2023
rexagod
commented
Nov 10, 2023
Closed
rexagod
force-pushed
the
add-krp
branch
3 times, most recently
from
12d7e44
to
775428c
Compare
rexagod
force-pushed
the
add-krp
branch
4 times, most recently
from
88c60c2
to
0a69c49
Compare
|
@simonpasquier Addressed the review comments, I believe this is good for another round of review (or merging). |
adds info about kube-rbac-proxy's high-level workflow
simonpasquier
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds info about kube-rbac-proxy's high-level workflow