Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewdog action-cpplint sample PR #2

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified entrypoint.sh
100755 → 100644
Empty file.
16 changes: 16 additions & 0 deletions testdata/test.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
//
#include <atomic>
#include "test.hpp"
#include <iostream>

Expand All @@ -13,9 +14,24 @@ class Hoge
int m_a;
};

// https://github.com/yohhoy/cpp-longest-identifier/wiki
bool longest_identifier()
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
{ should almost always be at the end of the previous line [whitespace/braces] [4]

std::atomic<int> x(3);

int expected = 3;
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

std::memory_order_acquire,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

std::memory_order_acquire);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]


std::cout << std::boolalpha << result << " " << x.load() << " " << expected << std::endl;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

return result;
}

int main(int, const char**)
{
Hoge hoge(42);
longest_identifier();
std::cout << hoge.getA() << std::endl;
return 0;
}