Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewdog action-cpplint sample PR #2

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

srz-zumix
Copy link
Collaborator

@srz-zumix srz-zumix commented Nov 29, 2019

this is sample PR, do not merge.

@srz-zumix srz-zumix changed the base branch from feature/cpplint to master December 5, 2019 03:21
@@ -13,9 +14,24 @@ class Hoge
int m_a;
};

// https://github.com/yohhoy/cpp-longest-identifier/wiki
bool longest_identifier()
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
{ should almost always be at the end of the previous line [whitespace/braces] [4]

std::atomic<int> x(3);

int expected = 3;
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]


int expected = 3;
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2,
std::memory_order_acquire,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

int expected = 3;
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2,
std::memory_order_acquire,
std::memory_order_acquire);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

std::memory_order_acquire,
std::memory_order_acquire);

std::cout << std::boolalpha << result << " " << x.load() << " " << expected << std::endl;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

std::atomic<int> x(3);

int expected = 3;
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]


int expected = 3;
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2,
std::memory_order_acquire,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

int expected = 3;
const bool result = std::atomic_compare_exchange_strong_explicit(&x, &expected, 2,
std::memory_order_acquire,
std::memory_order_acquire);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

std::memory_order_acquire,
std::memory_order_acquire);

std::cout << std::boolalpha << result << " " << x.load() << " " << expected << std::endl;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cpplint] reported by reviewdog 🐶
Lines should be <= 50 characters long [whitespace/line_length] [2]

@srz-zumix srz-zumix marked this pull request as draft November 4, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant