Allow relocating the signed RPM to a different path #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 17, 2020 13:55
If set, its value will be used to replace the path of the unsigned RPM (the RPM name will keep the same). This allows to upload the signed RPM in the same bucket as the unsigned RPM.
…allows to use the bucket from the event directly
…allows to use the bucket from the event directly
…lambda into allow-using-same-s3-bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces an optional
LAMBDA_S3_TARGET_PATH.When set, the signed RPM is copied to
LAMBDA_S3_TARGET:/LAMBDA_S3_TARGET_PATHinstead of the path of the uploaded RPM file that triggered the event calling the lambda.This allows to copy the signed RPM to the same S3 bucket as the one where the file was uploaded. To facilitate this,
LAMBDA_S3_TARGETcan be unset ifLAMBDA_S3_TARGET_PATHis set, in which case the S3 bucket of the event is used for the destination URL.