Allow relative paths #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 17, 2020 13:55
If set, its value will be used to replace the path of the unsigned RPM (the RPM name will keep the same). This allows to upload the signed RPM in the same bucket as the unsigned RPM.
…allows to use the bucket from the event directly
…allows to use the bucket from the event directly
…lambda into allow-using-same-s3-bucket
…BDA_S3_BASE_PATH along with LAMBDA_S3_TARGET_PATH. This allows to manage unsigned RPMs for multiple target repositories, e.g. with LAMBDA_S3_BASE_PATH set to /unsigned/, and LAMBDA_S3_TARGET_PATH set to /incoming/, if you copy an unsigned package to /unsigned/<repo1>/package-1.2.3-1.el7.centos.x86_64.rpm, the signed package will be copied to /incoming/<repo1>/package-1.2.3-1.el7.centos.x86_64.rpm, while /unsigned/<repo2>/package-1.3.1-1.el7.centos.x86_64.rpm will be copied to /incoming/<repo2>/package-1.3.1-1.el7.centos.x86_64.rpm. Replace <repo1> by "production" and <repo2> by "staging" and you should understand the rationale :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top #4 and allows to manage multiple paths/repositories with a single sign-package lambda.