KFLUXBUGS-863: introduce results fixes with requisite performance related tuning (dev/stage) #3884
Conversation
…/kustomization.yaml
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gabemontero
force-pushed
the
retry-results-watcher-mem-leak-fix
branch
from
3f58397 to
c3bffb8
Compare
|
pipeline service is not coming up ... will need to run this branch on a local cluster /hold |
…ated tuning (dev/stage) rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED
gabemontero
force-pushed
the
retry-results-watcher-mem-leak-fix
branch
from
c3bffb8 to
134f999
Compare
|
/hold cancel needed to undo image pinning on infra deployments side |
|
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
gabemontero
requested review from
enarha
and removed request for
xinredhat and
ramessesii2
|
The hac test failures were unrelated to results. In fact, the results based query worked: Also, all the calls in the api server looked clean. https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/redhat-appstudio_infra-deployments/3884/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-hac-e2e-tests/1801949874850107392/artifacts/appstudio-hac-e2e-tests/gather-extra/artifacts/pods/tekton-results_tekton-results-api-5598d57bb7-84z24_api.log The test did not run long enough for pruning to kick in. I think this is ready to merge into stage so I can run some performance testing, but I'll first wait to see if @enarha has cycles to review during his Sunday. |
| value: 1 |
There was a problem hiding this comment.
been backing off of multiple replicas since some odd behavior I saw during the March outage.
production is already back to 1 replica
| - behavior: merge | ||
| name: config-observability | ||
| literals: | ||
| - profiling.enable="true" |
There was a problem hiding this comment.
so we can get thread dumps if need be .... safe to run in prod per https://go.dev/doc/diagnostics
will not be turning on cpu profiling etc.
I see us turning on profiling for as many tekton controllers as possible in konflux as part of app sre reqs wrt thread dumps
| value: -update_log_timeout | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "9m" |
There was a problem hiding this comment.
based on performance testing with @pmacik
| value: -dynamic_reconcile_timeout | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "9m" |
There was a problem hiding this comment.
based on performance testing with @pmacik
|
lgtm |
openshift-merge-bot
bot
merged commit 4e63f61
into
redhat-appstudio:main
…ated tuning (dev/stage) (redhat-appstudio#3884) * update components/monitoring/grafana/base/dashboards/pipeline-service/kustomization.yaml * update components/pipeline-service/development/kustomization.yaml * update components/pipeline-service/staging/base/kustomization.yaml * update components/pipeline-service/staging/stone-stage-p01/deploy.yaml * update components/pipeline-service/staging/stone-stg-m01/deploy.yaml * update components/pipeline-service/staging/stone-stg-rh01/deploy.yaml * KFLUXBUGS-863: introduce results fixes with requisite performance related tuning (dev/stage) rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED --------- Co-authored-by: rh-tap-build-team[bot] <127938674+rh-tap-build-team[bot]@users.noreply.github.com>
…ated tuning (dev/stage) (redhat-appstudio#3884) * update components/monitoring/grafana/base/dashboards/pipeline-service/kustomization.yaml * update components/pipeline-service/development/kustomization.yaml * update components/pipeline-service/staging/base/kustomization.yaml * update components/pipeline-service/staging/stone-stage-p01/deploy.yaml * update components/pipeline-service/staging/stone-stg-m01/deploy.yaml * update components/pipeline-service/staging/stone-stg-rh01/deploy.yaml * KFLUXBUGS-863: introduce results fixes with requisite performance related tuning (dev/stage) rh-pre-commit.version: 2.3.0 rh-pre-commit.check-secrets: ENABLED --------- Co-authored-by: rh-tap-build-team[bot] <127938674+rh-tap-build-team[bot]@users.noreply.github.com>
changes from #3883 plus desired tuning to go with this results change
Replacement from attempt back with #3616
On the tekton side this is https://issues.redhat.com/browse/SRVKP-4347
@enarha @khrm @savitaashture FYI