pipeline-service update #3883
pipeline-service update #3883
Conversation
![rh-tap-build-team[bot]](https://avatars.githubusercontent.com/u/89927105?s=60&v=4){kind=small}
|
/hold need to couple this results bump with a backtrack in the pinning done in openshift-pipelines/pipeline-service#997 as well as a reintroduction / modification as needed of the results tuning from https://github.com/redhat-appstudio/infra-deployments/pull/3616/files |
rh-tap-build-team
bot
force-pushed
the
pipeline-service
branch
from
e2a9234 to
e95d2b1
Compare
|
moving forward with #3884 instead |
rh-tap-build-team
bot
force-pushed
the
pipeline-service
branch
from
e4ed47b to
199f0fc
Compare
rh-tap-build-team
bot
force-pushed
the
pipeline-service
branch
from
af5dc46 to
b1d6443
Compare
@gabemontero What does "instead" mean here? Are there any changes we need to drop from here? In addition I need to add some changes to the Results api configs we started to manage in infra-deployments e.g https://github.com/redhat-appstudio/infra-deployments/blob/main/components/pipeline-service/development/config.env#L6-L7, so I'll eventually close this PR and manually create a new one with the changes from this PR + the config changes I just mentioned. Another option is to merge that PR and open a new one only with the config changes, but then I need to go through the CI twice. Any preference WRT the 2 options? |
|
/test appstudio-e2e-tests |
|
/test appstudio-upgrade-tests |
|
/test appstudio-hac-e2e-tests |
this got opened before I did #3884 which has merged I cherrypicked the commits that were in this PR at the time into #3884 and then added the results config on top sorry I thought the automation would close this PR and create a new one after #3884 merged so I did not bother releasing the hold I'll do that now /hold cancel
I don't have preferences but fwiw I did the former approach with #3884 except I put the hold on this vs. closing. Avoiding going through CI twice does seem better. |
rh-tap-build-team
bot
force-pushed
the
pipeline-service
branch
from
5c4be55 to
b1d6443
Compare
|
/hold |
rh-tap-build-team
bot
force-pushed
the
pipeline-service
branch
2 times, most recently
from
a289adb to
8540173
Compare
rh-tap-build-team
bot
force-pushed
the
pipeline-service
branch
from
e7bb7a4 to
8540173
Compare
The update job had an issue and manual update is required.
Because of issue with the update job, updating manually.
Because of issue with the update job, updating manually.
|
/unhold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: enarha, rh-tap-build-team[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Included PRs: