Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-637: [release-4.18] Add default TSCs if not present to ensure even distribution of OSDs #2927

Merged
merged 1 commit into from
Dec 10, 2024
Merged

DFBUGS-637: [release-4.18] Add default TSCs if not present to ensure even distribution of OSDs #2927

merged 1 commit into from
Dec 10, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2913

/assign malayparida2000

@malayparida2000
Add default TSCs if not present to ensure even distribution of OSDs
94aa43a 
When parts of the placement spec, such as tolerations or node affinity,
are defined, the ocs-operator stops applying default placement specs,
including TSCs. The osd distribution may become potentially uneven in
absence of the TSC. Always adding default TSCs ensures consistent and
balanced OSD placement across nodes.

Signed-off-by: Malay Kumar Parida <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 6, 2024
Merged
@malayparida2000 malayparida2000 changed the title [release-4.18] Add default TSCs if not present to ensure even distribution of OSDs DFBUGS-637: [release-4.18] Add default TSCs if not present to ensure even distribution of OSDs Dec 6, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-637](https://issues.redhat.com//browse/DFBUGS-637), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #2913

/assign malayparida2000

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@malayparida2000
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Dec 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2024 •
edited by openshift-ci bot
Loading

@malayparida2000: This pull request references [Jira Issue DFBUGS-637](https://issues.redhat.com//browse/DFBUGS-637), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Dec 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3ea40bd into red-hat-storage:release-4.18 Dec 10, 2024
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2024 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue DFBUGS-637](https://issues.redhat.com//browse/DFBUGS-637): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-637](https://issues.redhat.com//browse/DFBUGS-637) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2913

/assign malayparida2000

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

Assignees

@iamniting iamniting

@malayparida2000 malayparida2000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @malayparida2000 @iamniting