Add default TSCs if not present to ensure even distribution of OSDs #2913

malayparida2000 · 2024-12-02T09:06:46Z

When parts of the placement spec, such as tolerations or node affinity, are defined, the ocs-operator stops applying default placement specs, including TSCs. The osd distribution may become potentially uneven in absence of the TSC. Always adding default TSCs ensures consistent and balanced OSD placement across nodes.

malayparida2000 · 2024-12-02T09:07:08Z

Ref-https://issues.redhat.com/browse/DFBUGS-637

malayparida2000 · 2024-12-02T09:12:48Z

/cc @travisn @iamniting

malayparida2000 · 2024-12-02T09:13:02Z

/hold for testing

When parts of the placement spec, such as tolerations or node affinity, are defined, the ocs-operator stops applying default placement specs, including TSCs. The osd distribution may become potentially uneven in absence of the TSC. Always adding default TSCs ensures consistent and balanced OSD placement across nodes. Signed-off-by: Malay Kumar Parida <[email protected]>

malayparida2000 · 2024-12-02T14:53:28Z

Test storagecluster, One deviceset with placement, another deviceset without placement.

cat <<EOF | oc create -f -
apiVersion: [ocs.openshift.io/v1](http://ocs.openshift.io/v1)
kind: StorageCluster
metadata:
  ownerReferences:
  - apiVersion: v1
    kind: StorageSystem
    name: ocs-storagecluster-storagesystem
    uid: ocs-storagecluster-storagesystem
  name: ocs-storagecluster
  namespace: openshift-storage
spec:
  storageDeviceSets:
    - name: without-placement
      dataPVCTemplate:
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: "1Ti"
          storageClassName: gp3-csi
          volumeMode: Block
      count: 1
      replica: 3
      portable: true
    - name: with-placement
      dataPVCTemplate:
        spec:
          accessModes:
            - ReadWriteOnce
          resources:
            requests:
              storage: "1Ti"
          storageClassName: gp3-csi
          volumeMode: Block
      count: 1
      replica: 3
      portable: true
      placement:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                - us-east-1
EOF

Without FIx-Deviceset placement on cephCluster CR

~ $ oc get cephcluster ocs-storagecluster-cephcluster -o yaml | yq '.spec.storage.storageClassDeviceSets[] | {"name": .name, "placement": .placement, "preparePlacement": .preparePlacement}' -P | sed 's/^/  /' | sed 's/^  name/- name/' 
- name: without-placement-0
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
- name: without-placement-1
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
- name: without-placement-2
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
- name: with-placement-0
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
- name: with-placement-1
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
- name: with-placement-2
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1

With Fix-DeviceSet Placement on CephCluster CR

~ $ oc get cephcluster ocs-storagecluster-cephcluster -o yaml | yq '.spec.storage.storageClassDeviceSets[] | {"name": .name, "placement": .placement, "preparePlacement": .preparePlacement}' -P | sed 's/^/  /' | sed 's/^  name/- name/'
- name: without-placement-0
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
- name: without-placement-1
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
- name: without-placement-2
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [cluster.ocs.openshift.io/openshift-storage](http://cluster.ocs.openshift.io/openshift-storage)
                operator: Exists
    tolerations:
      - effect: NoSchedule
        key: [node.ocs.openshift.io/storage](http://node.ocs.openshift.io/storage)
        operator: Equal
        value: "true"
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
- name: with-placement-0
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
- name: with-placement-1
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
                - rook-ceph-osd-prepare
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
- name: with-placement-2
  placement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [topology.rook.io/rack](http://topology.rook.io/rack)
        whenUnsatisfiable: DoNotSchedule
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In
              values:
                - rook-ceph-osd
        maxSkew: 1
        topologyKey: [kubernetes.io/hostname](http://kubernetes.io/hostname)
        whenUnsatisfiable: ScheduleAnyway
  preparePlacement:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
          - matchExpressions:
              - key: [topology.kubernetes.io/region](http://topology.kubernetes.io/region)
                operator: In
                values:
                  - us-east-1
    topologySpreadConstraints:
      - labelSelector:
          matchExpressions:
            - key: app
              operator: In

malayparida2000 · 2024-12-02T14:54:18Z

As seen in testing TSCs are getting applied as expected, Removing hold
/unhold

malayparida2000 · 2024-12-05T05:03:14Z

/cherry-pick release-4.18

openshift-cherrypick-robot · 2024-12-05T05:03:17Z

@malayparida2000: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2024-12-06T10:55:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-cherrypick-robot · 2024-12-06T12:40:49Z

@malayparida2000: new pull request created: #2927

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from iamniting and travisn December 2, 2024 09:12

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024

malayparida2000 force-pushed the osd_tsc branch from 739e804 to ed1c74d Compare December 2, 2024 13:41

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024

iamniting approved these changes Dec 6, 2024

View reviewed changes

openshift-ci bot assigned iamniting Dec 6, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024

openshift-merge-bot bot merged commit 1694063 into red-hat-storage:main Dec 6, 2024
11 checks passed

openshift-cherrypick-robot mentioned this pull request Dec 6, 2024

DFBUGS-637: [release-4.18] Add default TSCs if not present to ensure even distribution of OSDs #2927

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add default TSCs if not present to ensure even distribution of OSDs #2913

Add default TSCs if not present to ensure even distribution of OSDs #2913

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 5, 2024

openshift-cherrypick-robot commented Dec 5, 2024

openshift-ci bot commented Dec 6, 2024

openshift-cherrypick-robot commented Dec 6, 2024

Add default TSCs if not present to ensure even distribution of OSDs #2913

Add default TSCs if not present to ensure even distribution of OSDs #2913

Conversation

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 2, 2024

malayparida2000 commented Dec 5, 2024

openshift-cherrypick-robot commented Dec 5, 2024

openshift-ci bot commented Dec 6, 2024

openshift-cherrypick-robot commented Dec 6, 2024