Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the server side rpc calls for peering #2675

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Implement the server side rpc calls for peering #2675

merged 3 commits into from
Nov 7, 2024

Conversation

rewantsoni
Copy link
Member

@rewantsoni rewantsoni commented Jun 25, 2024 •
edited
Loading

@rewantsoni rewantsoni force-pushed the rpc-implementation branch from a023839 to 2ebffec Compare July 11, 2024 09:25
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2024
@rewantsoni rewantsoni force-pushed the rpc-implementation branch from 2ebffec to e3d0753 Compare July 22, 2024 07:48
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2024
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 2 times, most recently from e429275 to c77b642 Compare July 30, 2024 07:27
@rewantsoni
Copy link
Member Author

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 2 times, most recently from de75a18 to 4b9f669 Compare October 9, 2024 06:44
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 2 times, most recently from 0081e85 to 8eb6607 Compare October 17, 2024 07:02
leelavg
leelavg reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@leelavg leelavg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit of renaming to make distinction b/n local and remote resources will be good. I'll relook at a later point since I can't fully visualize the design and implementation.

services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/storageclusterpeer.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 4 times, most recently from caf5073 to 2bae212 Compare October 22, 2024 05:18
@rewantsoni rewantsoni requested a review from leelavg November 4, 2024 07:16
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 3 times, most recently from 75dc279 to df7f8c3 Compare November 6, 2024 04:46
@rewantsoni rewantsoni mentioned this pull request Nov 6, 2024
Merged
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 2 times, most recently from 75460c6 to 7b9e43c Compare November 6, 2024 13:45
nb-ohad
nb-ohad requested changes Nov 6, 2024
View reviewed changes
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/storageclusterpeer.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 2 times, most recently from 37bc8e3 to ce9eb7a Compare November 7, 2024 10:56
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 3 times, most recently from ba6f38e to 3271af9 Compare November 7, 2024 12:40
@rewantsoni rewantsoni mentioned this pull request Nov 7, 2024
Open
nb-ohad
nb-ohad requested changes Nov 7, 2024
View reviewed changes
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/storageclusterpeer.go Outdated Show resolved Hide resolved
services/provider/server/storageclusterpeer.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 4 times, most recently from 979797c to dc7d651 Compare November 7, 2024 14:55
nb-ohad
nb-ohad requested changes Nov 7, 2024
View reviewed changes
services/provider/server/storageclusterpeer.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the rpc-implementation branch 2 times, most recently from 06fe258 to 58f737b Compare November 7, 2024 15:14
@nb-ohad
Copy link
Contributor

nb-ohad commented Nov 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c079ab8 into red-hat-storage:main Nov 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchikatw rchikatw rchikatw left review comments

@nb-ohad nb-ohad nb-ohad requested changes

@leelavg leelavg Awaiting requested review from leelavg

Assignees

@nb-ohad nb-ohad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rewantsoni @nb-ohad @leelavg @rchikatw @openshift-merge-robot