Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers: add a new controller to setup mirroring #2878

Merged
merged 4 commits into from
Nov 26, 2024
Merged

controllers: add a new controller to setup mirroring #2878

merged 4 commits into from
Nov 26, 2024

Conversation

rewantsoni
Copy link
Member

@rewantsoni rewantsoni commented Nov 6, 2024 •
edited
Loading

Add two rpc calls required for setting up mirroring for blockpool and radosnamespace

  1. GetBlockPoolsInfo
  2. GetClientInfo

A new controller to enable mirroring for cephblockpool and radosnamespace

Depends On:

  1. Implement the server side rpc calls for peering #2675

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rewantsoni rewantsoni force-pushed the mirroring-controller branch 4 times, most recently from 1128536 to 4d36986 Compare November 6, 2024 12:05
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2024
@rewantsoni rewantsoni force-pushed the mirroring-controller branch from 4d36986 to e3e601b Compare November 6, 2024 12:09
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2024
@rewantsoni rewantsoni marked this pull request as ready for review November 6, 2024 12:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@rewantsoni rewantsoni force-pushed the mirroring-controller branch from e3e601b to 451b704 Compare November 8, 2024 06:18
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@rewantsoni rewantsoni force-pushed the mirroring-controller branch 3 times, most recently from 2c252fc to 64ce4ce Compare November 12, 2024 07:04
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@rewantsoni rewantsoni force-pushed the mirroring-controller branch 2 times, most recently from 0c6cd48 to 8cf94cb Compare November 13, 2024 18:51
umangachapagain
umangachapagain reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@umangachapagain umangachapagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having comments on code would definitely make it much easier for us to review it. This is such a big change and doesn't make any sense to me.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2024
@rewantsoni rewantsoni force-pushed the mirroring-controller branch 3 times, most recently from f86bf71 to 319272e Compare November 20, 2024 06:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024
nb-ohad
nb-ohad requested changes Nov 25, 2024
View reviewed changes
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storageclusterpeer/storageclusterpeer_controller.go Outdated Show resolved Hide resolved
controllers/storagerequest/storagerequest_controller.go Show resolved Hide resolved
controllers/util/k8sutil.go Outdated Show resolved Hide resolved
controllers/util/k8sutil.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the mirroring-controller branch 2 times, most recently from 139c3bb to 69a78de Compare November 25, 2024 17:24
nb-ohad
nb-ohad requested changes Nov 25, 2024
View reviewed changes
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the mirroring-controller branch 2 times, most recently from 5275b85 to 8561abe Compare November 26, 2024 05:15
nb-ohad
nb-ohad requested changes Nov 26, 2024
View reviewed changes
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the mirroring-controller branch 2 times, most recently from bd99d28 to 4c5c795 Compare November 26, 2024 10:12
nb-ohad
nb-ohad requested changes Nov 26, 2024
View reviewed changes
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
controllers/mirroring/mirroring_controller.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni force-pushed the mirroring-controller branch 4 times, most recently from 352ad26 to d05e238 Compare November 26, 2024 11:16
@nb-ohad
Copy link
Contributor

nb-ohad commented Nov 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@rewantsoni
Copy link
Member Author

/jira backport release-4.18

@openshift-ci-robot
Copy link

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5d188d4 into red-hat-storage:main Nov 26, 2024
11 checks passed
@openshift-cherrypick-robot
Copy link

@openshift-ci-robot: new pull request created: #2908

In response to this:

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18

In response to this:

/jira backport release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nb-ohad nb-ohad nb-ohad requested changes

@umangachapagain umangachapagain umangachapagain requested changes

Assignees

@umangachapagain umangachapagain

@nb-ohad nb-ohad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rewantsoni @nb-ohad @openshift-ci-robot @openshift-cherrypick-robot @umangachapagain @openshift-merge-robot