Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2283959:[release-4.16] Adding empty label selector for prom service monitor selector #2637

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2588

/assign ezio-auditore

Copy link
Contributor

openshift-ci bot commented May 30, 2024

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: ezio-auditore.

Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #2588

/assign ezio-auditore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamniting iamniting changed the title [release-4.16] Adding empty label selector for prom service monitor selector Bug 2283959:[release-4.16] Adding empty label selector for prom service monitor selector May 31, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 31, 2024
Copy link
Contributor

openshift-ci bot commented May 31, 2024

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2283959, which is invalid:

  • expected the bug to target the "ODF 4.16.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2283959:[release-4.16] Adding empty label selector for prom service monitor selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
Copy link
Contributor

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@iamniting
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 31, 2024
Copy link
Contributor

openshift-ci bot commented May 31, 2024

@iamniting: This pull request references Bugzilla bug 2283959, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ezio-auditore
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

1 similar comment
@ezio-auditore
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit 4aa46bf into red-hat-storage:release-4.16 Jun 10, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2283959 has been moved to the MODIFIED state.

In response to this:

Bug 2283959:[release-4.16] Adding empty label selector for prom service monitor selector

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants