Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding empty label selector for prom service monitor selector #2588

Merged

Conversation

ezio-auditore
Copy link
Contributor

@ezio-auditore ezio-auditore commented Apr 29, 2024

Introduced in #2465 the service monitor selector in the Prometheus configuration was marked wrongly,hence it was scraping metrics from only k8s-service-monitor. Adding an empty service monitor selector scrapes metrics from all Service monitors present in the namespace.
List of Service Monitors present in the namespace

k8s-metrics-service-monitor                      
noobaa-mgmt-service-monitor                    
ocs-metrics-exporter                            
odf-operator-controller-manager-metrics-monitor  
rook-ceph-exporter                              
rook-ceph-mgr                                    
s3-service-monitor                                

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezio-auditore, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 408f6e2 into red-hat-storage:main Apr 29, 2024
11 checks passed
@ezio-auditore
Copy link
Contributor Author

/cherry-pick release-4.16

@openshift-cherrypick-robot

@ezio-auditore: new pull request created: #2637

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants