Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2276055: [release-4.16] Sync provider mode changes from main #2578

Merged
merged 32 commits into from
Apr 22, 2024

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Apr 22, 2024

Manualy cherry-pick of #2547, #2563, #2550, #2568, #2573, #2570, #2569, #2571.

They are tightly coupled and couldn't be cherry-picked one by one. Majority of the commits are rename of storageclassrequest to storagerequest and storageclient scope change from namespacescope to clusterscope.

@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 22, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@leelavg: This pull request references Bugzilla bug 2276055, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2276055: [release-4.16] Sync provider mode changes from main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@leelavg: This pull request references Bugzilla bug 2276055, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2276055: [release-4.16] Sync provider mode changes from main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leelavg and others added 26 commits April 22, 2024 18:26
Signed-off-by: Leela Venkaiah G <[email protected]>
renamed the controller files for storageClassRequest to storageRequest

Signed-off-by: Rohan Gupta <[email protected]>
controller and main.go changes for renaming StorageClassRequest to
StorageRequest

Signed-off-by: Rohan Gupta <[email protected]>
renamed storageClassRequest to storageRequest in provider server api

Signed-off-by: Rohan Gupta <[email protected]>
renamed storageClassRequests to storageReqest in the manifests

Signed-off-by: Rohan Gupta <[email protected]>
generated code changes for renaming storageClassRequest to
storageRequest using make gen-latest-csv and make generate

Signed-off-by: Rohan Gupta <[email protected]>
This reverts commit 629351a.

Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg added 6 commits April 22, 2024 18:30
This reverts commit 015e679.

Signed-off-by: Leela Venkaiah G <[email protected]>
provider sends the ceph client secret name to onboarded consumer as gRPC
response, however if both provider & client operators running in same
namespaces the secrets referred will collide. So, we'll send different
secret names with same content to be created by client.

Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg
Copy link
Contributor Author

leelavg commented Apr 22, 2024

@nb-ohad @Madhu-1 only fyi... this is the provider content which was in main for 4.16

@iamniting could you pls approve? thanks.

@iamniting
Copy link
Member

@nb-ohad @Madhu-1 only fyi... this is the provider content which was in main for 4.16

@iamniting could you pls approve? thanks.

@leelavg Have all cherry-picks been thoroughly handled, ensuring there are no broken ones? Can I simply approve the backport?

@leelavg
Copy link
Contributor Author

leelavg commented Apr 22, 2024

yes, I counted & checked the commits a couple of times, there should be 32 for provider mode and those checks out release-4.16...main, I don't remember anyone else other than me & Rohan committing changes for provider mode.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 88c8da8 into red-hat-storage:release-4.16 Apr 22, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@leelavg: All pull requests linked via external trackers have merged:

Bugzilla bug 2276055 has been moved to the MODIFIED state.

In response to this:

Bug 2276055: [release-4.16] Sync provider mode changes from main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants