Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2276056: [release-4.16] Syncing latest changes from main #147

Merged
merged 51 commits into from
Apr 22, 2024

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Apr 22, 2024

No description provided.

bernerhat and others added 30 commits March 31, 2024 17:51
fixed ownership of resources and remove finalizer in deletion

Signed-off-by: Amit Berner <[email protected]>
Upgrades ocs-operator dependency
update opm version to be run on all os/arch

Signed-off-by: Rewant Soni <[email protected]>
following what downstream does and run the unit tests before
starting to build the container as if unit tests fail, we
shouldn't even start building the container

Signed-off-by: Rewant Soni <[email protected]>
as sqlite based catalog source is depricarted, move to file based
catalogsource

Signed-off-by: Rewant Soni <[email protected]>
update setup envtest to latest version and use the tool
instead of using script to run

Signed-off-by: Rewant Soni <[email protected]>
make development possible on different os/arch
Redesign for ClusterVersion controller into OperatorConfigMap controller
update ocs-client-operator subscription when all the storageclients
agree to a single subscription channel

Signed-off-by: Leela Venkaiah G <[email protected]>
implement ocs-client-operator auto upgrade
Fix placeholder kube-rbac-proxy image to respect supplied image during build time
update bundle w/ bumping version
since we are going to be installed alongside w/ odf-operator inorder to
conform to u/s CI changing the dependency of csi-addons from 0.5.0 to
0.8.0

Signed-off-by: Leela Venkaiah G <[email protected]>
update csi-addons dependency from 0.5.0 to 0.8.0
create a deletion phase and delete the csi drivers and scc upon operator's removal

Signed-off-by: Amit Berner <[email protected]>
Handle csi drivers and scc deletion
create a deletion phase and delete the csi drivers and scc upon operator's removal

Signed-off-by: Amit Berner <[email protected]>
Add a deletion safegaurd mechanism for csi resources
reconcile webhook service and deletion of webhook
openshift-merge-bot bot and others added 14 commits April 17, 2024 08:25
make storageclient api to clusterscope resource
rename storageclassclaim to storageclaim in gRPC methods
Makefile:
Deploy console only once, we were deploying console twice from the
start. We shouldn't add the deployment at parent & child Kustomization,
this PR removes erroneous addition at parent.
Original: #31

StorageClaim API:
Use correct printer columns

RBAC:
Add missing `delete` verb on webhook and SCC

ConfigMap controller:
Deletion phase wasn't getting trigerred due to incorrect nesting of else
statement. Set SCC name explicitly during deletion.

Claim controller:
Intermittent panic as `vsc.Status` itself is a pointer and should be
checked first.

Client controller:
Cronjob name was more than allowed characters, existing comment is
correct but code was missing in some earlier refreshes

Bundle:
Update of rbac, removal of erroneous `console` deployment, CRD printer
columns

Signed-off-by: Leela Venkaiah G <[email protected]>
controllers: fix rbac, controllers, bundle, Makefile
we can't create storageclaims from storageclassclaim withough migrating
the underlying storage and having this API & controllers might create
more problems than what is solves.

Signed-off-by: Leela Venkaiah G <[email protected]>
api: remove storageclassclaim api & migration controller
make value of storageclaim type case insensitive and consistent
Copy link

openshift-ci bot commented Apr 22, 2024

@leelavg: This pull request references Bugzilla bug 2276056, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2276056: [release-4.16] Syncing latest changes from main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Apr 22, 2024

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@leelavg: This pull request references Bugzilla bug 2276056, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.0) matches configured target release for branch (ODF 4.16.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2276056: [release-4.16] Syncing latest changes from main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leelavg
Copy link
Contributor Author

leelavg commented Apr 22, 2024

/hold

for ocs-operator PR to get merged.

Copy link

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leelavg
Copy link
Contributor Author

leelavg commented Apr 22, 2024

/unhold

red-hat-storage/ocs-operator#2578 is merged

@openshift-merge-bot openshift-merge-bot bot merged commit 35fae4c into release-4.16 Apr 22, 2024
19 checks passed
Copy link

openshift-ci bot commented Apr 22, 2024

@leelavg: All pull requests linked via external trackers have merged:

Bugzilla bug 2276056 has been moved to the MODIFIED state.

In response to this:

Bug 2276056: [release-4.16] Syncing latest changes from main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants