Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rotation of keys endpoint from ux-backend #2569

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Apr 19, 2024

existing mechanism is only working as a proxy for deletion of secret w/ no added value, so deleting this endpoint and UI will be wired to directly perform the operator.

ref: #2469

This reverts commit 629351a.

Signed-off-by: Leela Venkaiah G <[email protected]>
@leelavg leelavg changed the title Remove rotation of keys endpoint from ux-backend remove rotation of keys endpoint from ux-backend Apr 19, 2024
This reverts commit 015e679.

Signed-off-by: Leela Venkaiah G <[email protected]>
@nb-ohad
Copy link
Contributor

nb-ohad commented Apr 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2024
@nb-ohad
Copy link
Contributor

nb-ohad commented Apr 22, 2024

/approve

Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2024
@leelavg
Copy link
Contributor Author

leelavg commented Apr 22, 2024

/override ci/prow/ocs-operator-bundle-e2e-aws

[1782237453432655872](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/red-hat-storage_ocs-operator/2569/pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-bundle-e2e-aws/1782237453432655872)	#[2569](https://github.com/red-hat-storage/ocs-operator/pull/2569)
([a209a03](https://github.com/red-hat-storage/ocs-operator/pull/2569/commits/a209a0351ce77fe9aaafede17706752a44869e82)) by [leelavg](https://github.com/leelavg)	
08:08:21
1h33m37s	SUCCESS

Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@leelavg: leelavg unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/ocs-operator-bundle-e2e-aws

[1782237453432655872](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/red-hat-storage_ocs-operator/2569/pull-ci-red-hat-storage-ocs-operator-main-ocs-operator-bundle-e2e-aws/1782237453432655872)	#[2569](https://github.com/red-hat-storage/ocs-operator/pull/2569)
([a209a03](https://github.com/red-hat-storage/ocs-operator/pull/2569/commits/a209a0351ce77fe9aaafede17706752a44869e82)) by [leelavg](https://github.com/leelavg)	
08:08:21
1h33m37s	SUCCESS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamniting
Copy link
Member

/override ci/prow/ocs-operator-bundle-e2e-aws

Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

@iamniting: Overrode contexts on behalf of iamniting: ci/prow/ocs-operator-bundle-e2e-aws

In response to this:

/override ci/prow/ocs-operator-bundle-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 81bee97 into red-hat-storage:main Apr 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants