Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2255499: [release-4.15] Some minor changes/fixes to ux backend #2376

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2345

/assign leelavg

- Move content of services/types package to the services package
- Move onboading_tokens content into its own sub-package
- Separate msg handling into Distinct functions based on HTTP method
- fix onboarding_tokens invalid content type

Signed-off-by: nb-ohad <[email protected]>
@leelavg
Copy link
Contributor

leelavg commented Jan 5, 2024

/retitle Bug 2255499: [release-4.15] Some minor changes/fixes to ux backend

@openshift-ci openshift-ci bot changed the title [release-4.15] Some minor changes/fixes to ux backend Bug 2255499: [release-4.15] Some minor changes/fixes to ux backend Jan 5, 2024
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 5, 2024
Copy link
Contributor

openshift-ci bot commented Jan 5, 2024

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2255499, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2255499: [release-4.15] Some minor changes/fixes to ux backend

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2024
Copy link
Contributor

openshift-ci bot commented Jan 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7dca0b1 into red-hat-storage:release-4.15 Jan 6, 2024
14 checks passed
Copy link
Contributor

openshift-ci bot commented Jan 6, 2024

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2255499 has been moved to the MODIFIED state.

In response to this:

Bug 2255499: [release-4.15] Some minor changes/fixes to ux backend

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants