Some minor changes/fixes to ux backend #2345
Conversation
openshift-ci
bot
added
the
approved
nb-ohad
force-pushed
the
ux-backend-pkg-structure
branch
2 times, most recently
from
9a2576f to
10b1f3c
Compare
|
|
||
| var err error | ||
| func HandleMessage(w http.ResponseWriter, r *http.Request, tokenLifetimeInHours int) { |
There was a problem hiding this comment.
HandleRequest might sound and suit better for what we are doing 🤔
There was a problem hiding this comment.
For me, Request is the vehicle, Message is the content we want to handle.
|
/hold refer #2352 |
openshift-ci
bot
added
the
do-not-merge/hold
nb-ohad
force-pushed
the
ux-backend-pkg-structure
branch
2 times, most recently
from
b7779bb to
29fc004
Compare
|
LGTM, Please fix the commit lint check |
nb-ohad
force-pushed
the
ux-backend-pkg-structure
branch
2 times, most recently
from
365afca to
982ca02
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/lgtm |
|
@nb-ohad: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
- Move content of services/types package to the services package - Move onboading_tokens content into its own sub-package - Separate msg handling into Distinct functions based on HTTP method - fix onboarding_tokens invalid content type Signed-off-by: nb-ohad <[email protected]>
nb-ohad
force-pushed
the
ux-backend-pkg-structure
branch
from
982ca02 to
d1b45c0
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fba0390
into
red-hat-storage:main
|
/cherry-pick fusion-hci-4.14 |
|
@leelavg: new pull request created: #2367 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.15 |
|
@leelavg: new pull request created: #2376 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: nb-ohad [email protected]