CSV changes to remove ocs metrics exporter deployment #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
jmolmo
reviewed
Dec 11, 2023
There was a problem hiding this comment.
LGTM. I think we need to test this.
@umangachapagain Do we have test to get the list of metrics using the console ?
umangachapagain
force-pushed
the
exporter-csv-changes
branch
from
2708e77 to
da1343e
Compare
|
Testing of #2293 might be blocked due to resource conflicts with CSV. This PR is now updated to unblock it. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
iamniting
approved these changes
Dec 11, 2023
ocs-metrics-exporter is now deployed with every StorageCluster. We do not need to deploy it during operator installation anymore. Signed-off-by: Umanga Chapagain <[email protected]>
Signed-off-by: Umanga Chapagain <[email protected]>
ocs-metrics-exporter is no longer deployed via the CSV at operator install time. So, we do not need to generate the "ocs-metrics-exporter" serviceaccount and related ClusterRole and ClusterRoleBindings. Signed-off-by: Umanga Chapagain <[email protected]>
These changes include removal of ocs-metrics-exporter ServiceAccount and it's related RBACs from the operator bundle. Signed-off-by: Umanga Chapagain <[email protected]>
umangachapagain
force-pushed
the
exporter-csv-changes
branch
from
da1343e to
bd260f5
Compare
iamniting
approved these changes
Dec 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2b565e4
into
red-hat-storage:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will deploy metrics exporter as part of StorageCluster reconcile now. We don't need it in CSV anymore.