Enable MetricsExporter and PrometheusRules on each StorageCluster namespaces #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
3 times, most recently
from
9c3163c to
ad51dca
Compare
|
@aruniiird is this still WIP? |
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
2 times, most recently
from
cfcb1d7 to
58a9d9b
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
aruniiird
changed the title
umangachapagain
requested changes
Dec 8, 2023
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
from
58a9d9b to
21f4ac4
Compare
umangachapagain
requested changes
Dec 8, 2023
umangachapagain
requested changes
Dec 8, 2023
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
3 times, most recently
from
f8aa8b9 to
42a14e7
Compare
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
4 times, most recently
from
b7b9f4b to
cdf0cf4
Compare
umangachapagain
requested changes
Dec 11, 2023
umangachapagain
requested changes
Dec 11, 2023
umangachapagain
requested changes
Dec 11, 2023
jmolmo
suggested changes
Dec 11, 2023
There was a problem hiding this comment.
LGTM after addressing suggestions.
@aruniiird , can you comment briefly how have you tested the changes?
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
from
5b5a249 to
bbb9fba
Compare
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
from
ee2c993 to
22c80ad
Compare
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
7 times, most recently
from
1e4734b to
7af36ad
Compare
|
All the changes are done (except for the functional tests).
@jmolmo , fix is now tested. |
umangachapagain
requested changes
Dec 12, 2023
umangachapagain
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Please update the commit messages as per our Contribution Guide.
Commit details should explain what changed and why we changed it.
Also, would be nice to see test results for newly updated alerts.
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
4 times, most recently
from
c778247 to
86428e0
Compare
Updated the commit messages |
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
from
86428e0 to
e6fd970
Compare
openshift-merge-robot
added
the
needs-rebase
In a multi storagecluster scenario, we have to create the following resources on each of the storagecluster's namespace a. metrics exporter deployment and needed cluster roles b. exporter service and servicemonitor c. prometheus rules Signed-off-by: Arun Kumar Mohan <[email protected]>
In multicluster scenario, metric exporter should get resources only for the namespace which it is deployed to. Changes are backward compatible and should work on all scenarioes. Signed-off-by: Arun Kumar Mohan <[email protected]>
In a multicluster mode, each alert should have clear indication about which cluster and namespace from which the it is being fired. Signed-off-by: Arun Kumar Mohan <[email protected]>
aruniiird
force-pushed
the
multicluster-changes-to-metrics-exporter-n-prometheus-rules
branch
from
e6fd970 to
9ae46b2
Compare
openshift-merge-robot
removed
the
needs-rebase
umangachapagain
approved these changes
Dec 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aruniiird, umangachapagain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 000607b
into
red-hat-storage:main
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a multi storagecluster scenario, both metrics-exporter and PrometheusRules should be enabled on all the namespaces where the StorageClusters are installed.
Follow up PR: #2313