Add new field 'monCount' in storagecluster CR #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
reviewed
Oct 16, 2023
Nikhil-Ladha
force-pushed
the
configure-mon-count
branch
from
c8ad71e to
7d07158
Compare
iamniting
requested changes
Oct 17, 2023
Nikhil-Ladha
force-pushed
the
configure-mon-count
branch
from
7d07158 to
71738e0
Compare
Madhu-1
reviewed
Oct 17, 2023
Added a new field 'monCount' in storagecluster CR that takes in the custom mon count from user i.e, either 3 or 5. Also, updated the `getMonCount` function definition to remove the unused `nodeCount` param. Signed-off-by: Nikhil-Ladha <[email protected]>
Nikhil-Ladha
force-pushed
the
configure-mon-count
branch
from
71738e0 to
d6ce4a1
Compare
Madhu-1
approved these changes
Oct 17, 2023
iamniting
approved these changes
Oct 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, Madhu-1, Nikhil-Ladha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new field 'monCount' in storagecluster CR that takes in the custom mon count from user i.e, either 3 or 5. Also, updated the
getMonCountfunction definition to remove the unusednodeCountparam.