Add new field 'monCount' in storagecluster CR

Added a new field 'monCount' in storagecluster CR that takes in the custom mon count from user i.e, either 3 or 5. Also, updated the `getMonCount` function definition to remove the unused `nodeCount` param. Signed-off-by: Nikhil-Ladha <[email protected]>
red-hat-storage · Oct 17, 2023 · 7d07158 · 7d07158
1 parent 70fe874
commit 7d07158
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 6 deletions.
diff --git a/api/v1/storagecluster_types.go b/api/v1/storagecluster_types.go
@@ -171,6 +171,8 @@ type ManagedResourcesSpec struct {
 // ManageCephCluster defines how to reconcile the Ceph cluster definition
 type ManageCephCluster struct {
 	ReconcileStrategy string `json:"reconcileStrategy,omitempty"`
+	// +kubebuilder:validation:Enum=3;5
+	MonCount int `json:"monCount,omitempty"`
 }
 
 // ManageCephConfig defines how to reconcile the Ceph configuration

diff --git a/config/crd/bases/ocs.openshift.io_storageclusters.yaml b/config/crd/bases/ocs.openshift.io_storageclusters.yaml
@@ -655,6 +655,11 @@ spec:
                     description: ManageCephCluster defines how to reconcile the Ceph
                       cluster definition
                     properties:
+                      monCount:
+                        enum:
+                        - 3
+                        - 5
+                        type: integer
                       reconcileStrategy:
                         type: string
                     type: object

diff --git a/controllers/storagecluster/cephcluster.go b/controllers/storagecluster/cephcluster.go
@@ -435,7 +435,7 @@ func newCephCluster(sc *ocsv1.StorageCluster, cephImage string, nodeCount int, s
 				Image:            cephImage,
 				AllowUnsupported: allowUnsupportedCephVersion(),
 			},
-			Mon:             generateMonSpec(sc, nodeCount),
+			Mon:             generateMonSpec(sc),
 			Mgr:             generateMgrSpec(sc),
 			DataDirHostPath: "/var/lib/rook",
 			DisruptionManagement: rookCephv1.DisruptionManagementSpec{
@@ -696,7 +696,7 @@ func getMgrCount(arbiterMode bool) int {
 	return defaults.DefaultMgrCount
 }
 
-func getMonCount(nodeCount int, arbiter bool) int {
+func getMonCount(sc *ocsv1.StorageCluster, arbiter bool) int {
 	// return static value if overridden
 	override := os.Getenv(monCountOverrideEnvVar)
 	if override != "" {
@@ -708,6 +708,10 @@ func getMonCount(nodeCount int, arbiter bool) int {
 		}
 	}
 
+	if sc != nil && sc.Spec.ManagedResources.CephCluster.MonCount != 0 {
+		return sc.Spec.ManagedResources.CephCluster.MonCount
+	}
+
 	if arbiter {
 		return defaults.ArbiterModeMonCount
 	}
@@ -1050,17 +1054,17 @@ func generateStretchClusterSpec(sc *ocsv1.StorageCluster) *rookCephv1.StretchClu
 	return &stretchClusterSpec
 }
 
-func generateMonSpec(sc *ocsv1.StorageCluster, nodeCount int) rookCephv1.MonSpec {
+func generateMonSpec(sc *ocsv1.StorageCluster) rookCephv1.MonSpec {
 	if arbiterEnabled(sc) {
 		return rookCephv1.MonSpec{
-			Count:                getMonCount(nodeCount, true),
+			Count:                getMonCount(sc, true),
 			AllowMultiplePerNode: false,
 			StretchCluster:       generateStretchClusterSpec(sc),
 		}
 	}
 
 	return rookCephv1.MonSpec{
-		Count:                getMonCount(nodeCount, false),
+		Count:                getMonCount(sc, false),
 		AllowMultiplePerNode: statusutil.IsSingleNodeDeployment(),
 	}
 }

diff --git a/controllers/storagecluster/storagecluster_controller_test.go b/controllers/storagecluster/storagecluster_controller_test.go
@@ -1054,7 +1054,7 @@ func createFakeScheme(t *testing.T) *runtime.Scheme {
 func TestMonCountChange(t *testing.T) {
 	for nodeCount := 0; nodeCount <= 10; nodeCount++ {
 		monCountExpected := defaults.DefaultMonCount
-		monCountActual := getMonCount(nodeCount, false)
+		monCountActual := getMonCount(nil, false)
 		assert.Equal(t, monCountExpected, monCountActual)
 	}
 }

diff --git a/deploy/csv-templates/crds/ocs/ocs.openshift.io_storageclusters.yaml b/deploy/csv-templates/crds/ocs/ocs.openshift.io_storageclusters.yaml
@@ -655,6 +655,11 @@ spec:
                     description: ManageCephCluster defines how to reconcile the Ceph
                       cluster definition
                     properties:
+                      monCount:
+                        enum:
+                        - 3
+                        - 5
+                        type: integer
                       reconcileStrategy:
                         type: string
                     type: object

diff --git a/deploy/ocs-operator/manifests/storagecluster.crd.yaml b/deploy/ocs-operator/manifests/storagecluster.crd.yaml
@@ -654,6 +654,11 @@ spec:
                     description: ManageCephCluster defines how to reconcile the Ceph
                       cluster definition
                     properties:
+                      monCount:
+                        enum:
+                        - 3
+                        - 5
+                        type: integer
                       reconcileStrategy:
                         type: string
                     type: object